Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added validator version to report filename #403

Merged
merged 4 commits into from
Apr 24, 2024
Merged

feat: added validator version to report filename #403

merged 4 commits into from
Apr 24, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Apr 24, 2024

Summary:
Closes #401
This PR updates the naming convention of validation reports to include the validator version. This change affects both HTML, JSON report and system_errors.json name formats and the corresponding updates have been made in the database update process to reflect this new naming convention.

Expected Behavior:
With the changes introduced in this PR, the filenames for both HTML and JSON validation reports will now include the validator version, ensuring clearer traceability and management of report files across different validator versions.

Database Example:
Below is an example from the ValidationReport entity for feed mdb-101 demonstrating how the reports are named with the validator version included:

id validator_version validated_at html_report json_report
mdb-101-202404010645_5.0.2-SNAPSHOT 5.0.2-SNAPSHOT 2024-04-24 15:25:07+00 https://dev-files.mobilitydatabase.org/mdb-101/mdb-101-202404010645/report-5.0.2-SNAPSHOT.html https://dev-files.mobilitydatabase.org/mdb-101/mdb-101-202404010645/report-5.0.2-SNAPSHOT.json

Testing tips:
Follow testing tips from #383.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as ready for review April 24, 2024 15:40
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y cka-y merged commit e7f04f4 into main Apr 24, 2024
7 checks passed
@cka-y cka-y deleted the feat/401 branch April 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change report filenames to include version number
2 participants