feat: added validator version to report filename #403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #401
This PR updates the naming convention of validation reports to include the validator version. This change affects both HTML, JSON report and
system_errors.json
name formats and the corresponding updates have been made in the database update process to reflect this new naming convention.Expected Behavior:
With the changes introduced in this PR, the filenames for both HTML and JSON validation reports will now include the validator version, ensuring clearer traceability and management of report files across different validator versions.
Database Example:
Below is an example from the
ValidationReport
entity for feedmdb-101
demonstrating how the reports are named with the validator version included:Testing tips:
Follow testing tips from #383.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything