Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new designs for individual Feed pages #511

Merged
merged 21 commits into from
Jun 27, 2024
Merged

feat: new designs for individual Feed pages #511

merged 21 commits into from
Jun 27, 2024

Conversation

indraneel
Copy link
Contributor

@indraneel indraneel commented Jun 26, 2024 •
edited
Loading

Summary:

Screen Shot 2024-06-25 at 3 30 38 PM
image
Screen Shot 2024-06-25 at 3 21 32 PM

Testing tips:

Navigate to an individual feed page to see the new designs reflected.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@github-actions GitHub Actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-511-f80nwuy9.web.app

@Alessandro100
Copy link
Contributor

Screenshot 2024-06-27 at 09 15 38

Can you add some margin to the chips and header, and align the buttons to the left to match the rest

@indraneel
Copy link
Contributor Author

indraneel commented Jun 27, 2024 •
edited
Loading

Resolved all above Typography and Chevron issues @Alessandro100

Also:

Screenshot 2024-06-27 at 09 15 38

Can you add some margin to the chips and header, and align the buttons to the left to match the rest

Sure, changed:
image

This was linked to issues Jun 27, 2024
Final GTFS Schedule feed page: Dataset history #465
Closed
Final GTFS Realtime feed page: Feed Summary and Related Schedule Feeds #466
Closed
Modify data quality summary section of feed page to use unique_counts #490
Closed
@indraneel indraneel self-assigned this Jun 27, 2024
@indraneel indraneel added the feed page All changes associated with displaying individual feed pages. label Jun 27, 2024
@indraneel indraneel added this to the User interface beta milestone Jun 27, 2024
Alessandro100
Alessandro100 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff, looks good! I like the way you structured the code

@indraneel
feat: for GTFS-RT feeds, fetch related feeds to get data info
5b8e3a6 
this replaces previous behavior that would just render IDs
@indraneel
Copy link
Contributor Author

Added ability to get data about related Schedule feeds on Realtime Feed pages -- @Alessandro100 I know you approved but if you want to take a look
image

@indraneel indraneel merged commit cc8042c into main Jun 27, 2024
4 checks passed
@indraneel indraneel deleted the feat/464-schedule-feed-page branch June 27, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alessandro100 Alessandro100 Alessandro100 approved these changes

@davidgamez davidgamez Awaiting requested review from davidgamez

Assignees

@indraneel indraneel

Labels
feed page All changes associated with displaying individual feed pages.
Projects
None yet
Milestone
User interface beta
2 participants
@indraneel @Alessandro100