Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create database instance on GCP #64

Merged
merged 88 commits into from
Aug 10, 2023
Merged

feat: Create database instance on GCP #64

merged 88 commits into from
Aug 10, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Aug 1, 2023

Summary:

  • Create terraform script to generate instances

For DEV:

  • Use terraform script to generate dev instance
  • Run Liquibase changes on it
  • Add option to populate database
  • Clear database if populate option is enabled
  • Populate the database using the spreadsheet version of the database

Example of the workflow for the update and population of the DEV instance

For QA:

  • Use terraform script to generate dev instance
  • Run Liquibase changes on it
    ... TODO @jcpitre

Closes #15
Closes #13

Known issue: Database generation doesn't work with python 3.11 and newer. TODO open issue and link it @cka-y

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as draft August 1, 2023 14:18
@cka-y cka-y changed the title Feat/13 feat: Create database instance on GCP Aug 2, 2023
infra/postgresql/main.tf Show resolved Hide resolved
.github/workflows/db-deployer.yml Outdated Show resolved Hide resolved
@cka-y cka-y marked this pull request as ready for review August 9, 2023 18:06
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jcpitre and @cka-y 🥇

@davidgamez davidgamez merged commit bfb15b7 into main Aug 10, 2023
@davidgamez davidgamez deleted the feat/13 branch August 10, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor changes to DB schemas Create database instance on GCP - [pre-prod, dev]
3 participants