-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super compatibility changes and example enhancement #11
Conversation
Ah. Once we get automated testing working it will test that your code works in both python 3 and 2.7 automatically, so it'll be easier to deal with this. Did you intend to CLOSE this, @sgill2 , or merge it? |
Also, does this resolve #9? |
I intended to merge this, but for some reason I'm getting some conflicts with the README.md that I can't automatically merge (I just added a line of text). So I was trying to fix that. |
And this should resolve #9. |
Ah, OK. Just leave it open, then when you fix the conflict, add a new commit with the conflict fixed and it will automatically update this PR. (Please do also use a descriptive title aside from "Sam branch"). |
(i.e. "SamBranch" is a fine name for a branch but you want to give a PR a title which says what it does.) |
Changed several things to address issues. Namely changed the super.init() to properly work in python2.7, and updated examples.