Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super compatibility changes and example enhancement #11

Merged
merged 9 commits into from
Nov 22, 2016
Merged

Conversation

sgill2
Copy link
Collaborator

@sgill2 sgill2 commented Nov 22, 2016

Changed several things to address issues. Namely changed the super.init() to properly work in python2.7, and updated examples.

@sgill2 sgill2 closed this Nov 22, 2016
@davidlmobley
Copy link
Member

Ah. Once we get automated testing working it will test that your code works in both python 3 and 2.7 automatically, so it'll be easier to deal with this.

Did you intend to CLOSE this, @sgill2 , or merge it?

@davidlmobley
Copy link
Member

Also, does this resolve #9?

@sgill2
Copy link
Collaborator Author

sgill2 commented Nov 22, 2016

I intended to merge this, but for some reason I'm getting some conflicts with the README.md that I can't automatically merge (I just added a line of text). So I was trying to fix that.

@sgill2
Copy link
Collaborator Author

sgill2 commented Nov 22, 2016

And this should resolve #9.

@davidlmobley
Copy link
Member

Ah, OK. Just leave it open, then when you fix the conflict, add a new commit with the conflict fixed and it will automatically update this PR.

(Please do also use a descriptive title aside from "Sam branch").

@sgill2 sgill2 reopened this Nov 22, 2016
@davidlmobley
Copy link
Member

(i.e. "SamBranch" is a fine name for a branch but you want to give a PR a title which says what it does.)

@sgill2 sgill2 changed the title Sam branch Super compatibility changes and example enhancement Nov 22, 2016
@sgill2 sgill2 merged commit c452c57 into master Nov 22, 2016
@davidlmobley davidlmobley mentioned this pull request Nov 22, 2016
nathanmlim pushed a commit that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants