Various additions #41
danielbadylint.yml
on: pull_request
run-swiftlint
12s
run-swiftformat
9s
Annotations
10 errors and 12 warnings
|
run-swiftlint:
Sources/Clients/PlaylistHistoryClient/Live.swift#L21
Line should be 175 characters or less; currently it has 199 characters (line_length)
|
|
run-swiftlint:
Sources/Clients/PlaylistHistoryClient/Live.swift#L47
Line should be 175 characters or less; currently it has 180 characters (line_length)
|
|
run-swiftlint:
Sources/Clients/PlaylistHistoryClient/Live.swift#L72
Line should be 175 characters or less; currently it has 181 characters (line_length)
|
|
run-swiftlint:
Sources/Clients/PlaylistHistoryClient/Live.swift#L81
Line should be 175 characters or less; currently it has 180 characters (line_length)
|
|
run-swiftlint:
Sources/Features/VideoPlayer/VideoPlayerFeature+Reducer.swift#L47
Line should be 175 characters or less; currently it has 184 characters (line_length)
|
|
run-swiftlint:
Sources/Features/VideoPlayer/VideoPlayerFeature+Reducer.swift#L315
Line should be 175 characters or less; currently it has 180 characters (line_length)
|
|
run-swiftlint:
Sources/Features/VideoPlayer/VideoPlayerFeature+Reducer.swift#L381
Line should be 175 characters or less; currently it has 180 characters (line_length)
|
|
run-swiftlint:
Sources/Features/ContentCore/ContentCore.swift#L92
Line should be 175 characters or less; currently it has 192 characters (line_length)
|
|
run-swiftlint:
Sources/Features/ContentCore/ContentCore.swift#L157
Line should be 175 characters or less; currently it has 199 characters (line_length)
|
|
run-swiftlint:
Sources/Features/Discover/WebView.swift#L38
Force unwrapping should be avoided (force_unwrapping)
|
|
run-swiftformat
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run-swiftlint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run-swiftlint:
Sources/Clients/UserSettingsClient/Live.swift#L27
TODOs should be resolved (Save UserSettingsClient) (todo)
|
|
run-swiftlint:
Sources/Clients/PlayerClient/Internal/PlayerItem.swift#L51
TODOs should be resolved (Validate if this is allowed or...) (todo)
|
|
run-swiftlint:
Sources/Clients/PlayerClient/Live.swift#L133
TODOs should be resolved (Fix issue with options not set...) (todo)
|
|
run-swiftlint:
Sources/Clients/PlayerClient/Live.swift#L450
TODOs should be resolved (Download url image if not in c...) (todo)
|
|
run-swiftlint:
Sources/Clients/PlayerClient/Internal/PlayerItem+DASH.swift#L261
Declaration makeMasterM3U8 contains the term "master" which is not considered inclusive (inclusive_language)
|
|
run-swiftlint:
Sources/Clients/PlayerClient/Client.swift#L28
TODOs should be resolved (Create Custom AVPlayer and AVP...) (todo)
|
|
run-swiftlint:
Sources/Clients/PlayerClient/Models.swift#L15
TODOs should be resolved (Add metadata in the status) (todo)
|
|
run-swiftlint:
Sources/Clients/PlayerClient/Models.swift#L44
TODOs should be resolved (List out option types, quality...) (todo)
|
|
run-swiftlint:
Sources/Clients/ModuleClient/Extensions/JSValue+.swift#L74
TODOs should be resolved (Allow stack trace) (todo)
|
|
run-swiftlint:
Sources/Clients/ModuleClient/Live.swift#L54
TODOs should be resolved (Check if the module is cached ...) (todo)
|