feat(world & server): Implement Spawn Limit API #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
src/main/java/be/seeseemelk/mockbukkit/configuration/ServerConfiguration.java
Show resolved
Hide resolved
| // TODO Auto-generated method stub | ||
| throw new UnimplementedOperationException(); | ||
| Preconditions.checkArgument(spawnCategory != null, "SpawnCategory cannot be null"); | ||
| Preconditions.checkArgument(spawnCategory != SpawnCategory.MISC, |
There was a problem hiding this comment.
This check does not consider if a new spawn limit has been implemented in paper. It would be good if something like an UnimplementedOperationException gets thrown whenever that is the case.
Thorinwasher
reviewed
Dec 5, 2023
|
seeseemelk
approved these changes
Feb 7, 2024
thelooter
added a commit
that referenced
this pull request
Feb 13, 2024
* fix playerlist hasplayedbefore (#944) * Implemented more methods in SkullMetaMock and PotionEffectType (#945) * Implemented more functions in SkullMetaMock * Implemented createEffect in PotionEffectType * fix merge conflicts * Requested changes * feat(entities): Implement Rest of Chicken Methods (#925) Co-authored-by: Thorinwasher <37477983+Thorinwasher@users.noreply.github.com> * chore(stubbing): Add method stubs for visual Blockdata API in TNTPrimed (#950) * chore(stubbing): Stub Paper Methods (#951) * Implement getOfflinePlayerIfCached with tests (#947) * Implement getOfflinePlayerIfCached with tests * Fix formatting * Fix more formatting * Adds Mocks for both Boat and ChestBoat (#851) * Adds Mocks for both Boat and ChestBoat * chore(boats): Implement Changes * feat(entities): Remove Loottable API from Chestboat and add getType * Fix formatting --------- Co-authored-by: Thorinwasher <ragnarlol96@gmail.com> Co-authored-by: Thorinwasher <37477983+Thorinwasher@users.noreply.github.com> * chore(deps): update dependency gradle to v8.6 (#954) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.junit.jupiter:junit-jupiter to v5.10.2 (#955) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add PigZombieMock (#957) * add PigZombieMock * fix paper implementation && added descriptive names * update unit tests * remove field unused * Fix WorkbenchInventoryMock#setMatrix (#960) * chore(deps): update gradle/wrapper-validation-action action to v2 (#952) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-java action to v4 (#915) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/cache action to v4 (#948) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(world & server): Implement Spawn Limit API (#909) * feat(world & server): Implement Spawn Limit API * Fix merge issues --------- Co-authored-by: Thorinwasher <ragnarlol96@gmail.com> * Fix merge issues --------- Co-authored-by: J3fftw <44972470+J3fftw1@users.noreply.github.com> Co-authored-by: thelooter <evekolb2204@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Nirbose <62440475+Nirbose@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the Spawn Limits API
Checklist
The following items should be checked before the pull request can be merged.