Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated SRG method #14

Closed
matthewprenger opened this issue Mar 8, 2015 · 3 comments
Closed

Duplicated SRG method #14

matthewprenger opened this issue Mar 8, 2015 · 3 comments
Labels

Comments

@matthewprenger
Copy link
Collaborator

Both IWorldNameable and ICommandSender have the following srg methods: func_145748_c_, func_70005_c_. Neither of these classes extends from the other.

@bspkrs
Copy link
Contributor

bspkrs commented Mar 9, 2015

I remember something about this from the 1.8 bot update... I'll see if I can dig up the explanation.

@jeffreykog
Copy link

Entity implements ICommandSender. EntityMinecart implements IWorldNameable. EntityMinecart extends Entity. That would be the reason they have the same name in srg.

In the obfuscated minecraft jar, they both have the same obfuscated name, and there is a central implementation in Entity, and also in EntityMinecart.

Because this name is used for far more than just ICommandSender, i think the name for this method is misleading, and should be renamed to a more generic getName

@matthewprenger
Copy link
Collaborator Author

Oh I didn't see that. That explains the duplication. And I agree, getName would be a much better method name, since it doesn't just apply to command senders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants