MODE-2254 Changed the JsonSidecarExtraPropertiesStore to avoid trying to interpret string properties as dates by default and also fixed a potential StringIndexOutOfBounds exception when converting ISO 8601 strings to dates. #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2014 16:18
…tempt to add more children than the size of the current page.
… to interpret string properties as dates by default and also fixed a potential StringIndexOutOfBounds exception when converting ISO 8601 strings to dates.
|
Apart from one minor question above, this looks good. |
rhauch
added a commit
that referenced
this pull request
Jul 15, 2014
MODE-2254 Changed the JsonSidecarExtraPropertiesStore to avoid trying to interpret string properties as dates by default and also fixed a potential StringIndexOutOfBounds exception when converting ISO 8601 strings to dates.
|
Merged into the 'master' branch. |
rhauch
added a commit
that referenced
this pull request
Jul 16, 2014
MODE-2254 Changed the JsonSidecarExtraPropertiesStore to avoid trying to interpret string properties as dates by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.