MODE-2518: Attach binary content jcr:content #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String display = values(def, p); | ||
| String value = p.isMultiple() ? multiValue(p) | ||
| : singleValue(p, def, repository, workspace, path); | ||
| list.add(new JcrProperty(name, type, value, display)); | ||
| } catch (PathNotFoundException e) { |
There was a problem hiding this comment.
should this exception be ignored ?
There was a problem hiding this comment.
yes. it means that property is not assign yet.
|
@rhauch are you ok with merging this ? |
|
@hchiorean, looks good. |
hchiorean
pushed a commit
that referenced
this pull request
Jan 8, 2016
MODE-2518: Attach binary content jcr:content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug when property with null value (ie just created node) is not displayed by property editor.