Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using profile-based credentials for S3 binary storage #1657

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Support using profile-based credentials for S3 binary storage #1657

merged 1 commit into from
Apr 28, 2017

Conversation

dalbani
Copy link
Contributor

@dalbani dalbani commented Apr 28, 2017

@hchiorean
Copy link
Member

hchiorean commented Apr 28, 2017

@dalbani
Copy link
Contributor Author

dalbani commented Apr 28, 2017

@hchiorean
I will a new entry in modeshape-s3-binary-storage.xml then.
But I don't really see how I'm supposed to alter S3BinaryStoreTest.java to test the profile credentials feature. Any idea?

@hchiorean
Copy link
Member

hchiorean commented Apr 28, 2017

@dalbani I didn't see that that S3BinaryStoreTest mocks everything... in this case I doubt a test would really be useful.

So just the test for the AS subsystem is ok.

@dalbani
Copy link
Contributor Author

dalbani commented Apr 28, 2017

Test entry added.

@hchiorean
Copy link
Member

please squash the 2 commits; everything else looks fine

@dalbani
Copy link
Contributor Author

dalbani commented Apr 28, 2017

Squashed.

@hchiorean hchiorean merged commit d4958a2 into ModeShape:master Apr 28, 2017
@dalbani dalbani deleted the MODE-2693 branch April 28, 2017 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants