MODE-1462 - Updated logging: #393
Conversation
hchiorean
commented
May 29, 2012
hchiorean
commented
- moved all logging classes to common.logging instead of common.util
- added logging factory & logger for pure Log4j support
- changed logging dependencies scope from "compile" to "provided"
- added a logger abstraction in modeshape-jcr-api and an implementation in modeshape-jcr which should be used for extensions
- updated Sequencer and TextExtractor base classes so that upon creation, they are provided with the extension logger
- moved all logging classes to common.logging instead of common.util - added logging factory & logger for pure Log4j support - changed logging dependencies scope from <compile> to <provided> - added a logger abstraction in modeshape-jcr-api and an implementation in modeshape-jcr which should be used for extensions - updated Sequencer and TextExtractor base classes so that upon creation, they are provided with the extension logger
| @@ -62,7 +54,7 @@ | |||
| * @return the current locale used for logging, or null if the system locale is used | |||
| * @see #setLoggingLocale(Locale) | |||
| */ | |||
| public static Locale getLoggingLocale() { | |||
| public Locale getLoggingLocale() { | |||
There was a problem hiding this comment.
What do you think about making this method final? It's now called inside each of the various log methods (which we want to be as fast as possible), so adding 'final' makes it more likely (all things considered) to be inlined.
There was a problem hiding this comment.
sounds good, will update
There was a problem hiding this comment.
Actually, I shouldn't have made the method non-static, because it hides the intent - all the loggers share the same locale - so I'll make it static, so final won't make sense really
|
One more question. Does this mean that many/most/all of our sequencer implementations no longer need to depend on |
|
They still do (most of them) mainly because of the annotations. There's also a few (ddl most notably) which uses also the .text and .component subpackages from common. |
