MODE-1128 Eliminated the dependency on JCIP and its annotations #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the POM and Java source to eliminate the dependency on JCIP annotations. ModeShape was using only 4 of the annotations (number of corresponding import statements is listed in parentheses): net.jcip.annotations.GuardedBy (10) net.jcip.annotations.Immutable (310) net.jcip.annotations.NotThreadSafe (95) net.jcip.annotations.ThreadSafe (97) These were replaced with new annotations in 'org.modeshape.common.annotation' that are semantically and lexically the same as the JCIP annotations. The 'net.jcip' dependency was removed from all POMs. This change should be backward compatible. If user code is explicitly using these annotations within Maven projects, they will have to have explicit dependencies, and when upgrading to 2.5.0.Beta2 they will not have any issues. Similarly, non-Maven projects will already have the JCIP JAR on their classpath, and can remove the library if they are not explicitly using it. All unit and integration tests continue to pass with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the POM and Java source to eliminate the dependency on JCIP annotations. ModeShape was using only 4 of the annotations (number of corresponding import statements is listed in parentheses):
These were replaced with new annotations in 'org.modeshape.common.annotation' that are semantically and lexically the same as the JCIP annotations.
The 'net.jcip' dependency was removed from all POMs. This change should be backward compatible. If user code is explicitly using these annotations within Maven projects, they will have to have explicit dependencies, and when upgrading to 2.5.0.Beta2 they will not have any issues. Similarly, non-Maven projects will already have the JCIP JAR on their classpath, and can remove the library if they are not explicitly using it.
All unit and integration tests continue to pass with these changes.