Mode 1587 - Updated the ModeShape kit so that it works with AS 7.2.0 #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 4, 2013 14:47
…S7.2 server and re-enabled the integration tests modules. However, for a local build to work, one needs for the time being a locally installed (via Maven) version of AS7.2. In the process of updating the kit, a couple of other things were updated: - exception processing around WritableSessionCache#persistChanges - logging of exceptions / errors in the ModeShape Webdav Servlet
…v6 profiles. By default, neither IPv4 nor IPv6 will be forced, meaning that whatever the underlying OS supports will be used (see http://docs.oracle.com/javase/1.5.0/docs/guide/net/ipv6_guide/index.html for more information) Also, It seems that on Windows (at least) JGroups 3.2 is a lot faster when using IPv6 than it is when using IPv4, so a new OS-dependent profile was added to modeshape-jcr. Also, it seems Arquillian doesn't work with IPv6, so IPv4 was enforced for the integration tests.
…le into dedicated profiles, so that user can still run "mvn clean install". We should keep this at least until we know what the Maven availability of the AS7 dist zip will be.
|
Merged into the 'master' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the kit/integration tests to be able to build & run, one needs do a mvn install -Prelease locally, on an AS 7.2.0.Final project.
For users to still be able to build ModeShape without problems, the AS7 kit modules have been moved from the standard build list and into dedicated profiles: integration, assembly, performance.
This PR contains an additional commit, which cleans up/changes IPv4 and IPv6 system properties usage, as it turns out they can have a significant performance impact.