Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model_diagnostics is not working when data is a matrix #355

Closed
pbiecek opened this issue Nov 9, 2020 · 0 comments · Fixed by #356
Closed

model_diagnostics is not working when data is a matrix #355

pbiecek opened this issue Nov 9, 2020 · 0 comments · Fixed by #356
Labels
bug 💣 Bug to fix R 🐳 Related to R

Comments

@pbiecek
Copy link
Member

pbiecek commented Nov 9, 2020

For XGBoost models the data is usually of type matrix.
In such cases model_diagnostics gives a WARNING due to

results$y <- explainer$y

The $ works for data.frames.
Replace with cbind is possible.
@pbiecek pbiecek added bug 💣 Bug to fix R 🐳 Related to R labels Nov 9, 2020
hbaniecki added a commit that referenced this issue Nov 9, 2020
@hbaniecki
potential fix for #355
e6fed31
@hbaniecki hbaniecki mentioned this issue Nov 9, 2020
Merged
hbaniecki added a commit that referenced this issue Nov 12, 2020
@hbaniecki
[R] fix model_diagnostics with matrix data (#356)
920398c 
* potential fix for #355

* result as data.frame

* do the same but smarter

* Update DESCRIPTION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 💣 Bug to fix R 🐳 Related to R
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[R] fix model_diagnostics with matrix data ModelOriented/DALEX
1 participant
@pbiecek