Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] fix model_diagnostics with matrix data #356

Merged
merged 4 commits into from
Nov 12, 2020
Merged

[R] fix model_diagnostics with matrix data #356

merged 4 commits into from
Nov 12, 2020

Conversation

hbaniecki
Copy link
Member

fixes #355

@hbaniecki hbaniecki added the R 🐳 Related to R label Nov 9, 2020
pbiecek
pbiecek reviewed Nov 11, 2020
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
R/model_diagnostics.R Show resolved Hide resolved
@hbaniecki
Copy link
Member Author

Two reasons for data.frame result:

  • model_diagnostics output was never matrix, because this error existed
  • ggplot2 doesn't work with matrix

pbiecek
pbiecek approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@pbiecek pbiecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@hbaniecki hbaniecki merged commit 920398c into master Nov 12, 2020
@hbaniecki hbaniecki deleted the r-fix-#355 branch November 24, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbiecek pbiecek pbiecek approved these changes

@maksymiuks maksymiuks Awaiting requested review from maksymiuks

Assignees
No one assigned
Labels
R 🐳 Related to R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

model_diagnostics is not working when data is a matrix
2 participants
@hbaniecki @pbiecek