Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty figuring out valid values for fairness_metrics argument in metric_scores function #29

Closed
FrieseWoudloper opened this issue Oct 7, 2020 · 1 comment
Labels
documentation 📖 Improvements or additions to documentation

Comments

@FrieseWoudloper
Copy link

It was difficult for me to figure out valid values for the fairness_metrics argument for the function metric_scores. The Usage section of the help says:

metric_scores(x, fairness_metrics = fairness_check_metrics())

However, fairness_check_metrics is a helper function that is not exposed. So I don't think it should be mentioned.

Also the Arguments section says:

fairness_metrics character, vector with fairness metric names. Default metrics are ones in fairness_check plot

However, the plot doesn't give the exact valid argument values.

From the Examples section:

ms <- metric_scores(fobject, fairness_metrics = c("TPR","STP","ACC"))

The meaning of TPR and ACC I could easily guess, but for me it wasn't immediately clear what STP stands for.

So maybe it would be better to explicitly state all valid values, including a full description?

@jakwisn jakwisn added the documentation 📖 Improvements or additions to documentation label Oct 7, 2020
@jakwisn
Copy link
Member

jakwisn commented Oct 10, 2020

Hi @FrieseWoudloper, thanks for all the issues! I changed fairness_check_metrics() to explicitly stating metrics c('ACC', 'TPR', 'PPV', 'FPR', 'STP'), I think it will be helpful. I know that these metric names abbreviations are sometimes difficult to decipher so now when a user has to state some metric name, the documentation will point to the fairness_check function documentation, where every abbreviation is explained. I also did changes according to your other issues (#26 , #27, #28). Thanks for using fairmodels.

@jakwisn jakwisn closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants