Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant number rounding doesn't seem right #61

Closed
hbaniecki opened this issue Nov 18, 2019 · 1 comment
Closed

Significant number rounding doesn't seem right #61

hbaniecki opened this issue Nov 18, 2019 · 1 comment
Labels
invalid ❕ This doesn't seem right

Comments

@hbaniecki
Copy link
Member

hbaniecki commented Nov 18, 2019

library("DALEX")
library("randomForest")
apartments_rf_model <- randomForest(m2.price ~ construction.year + surface + floor +
                                      no.rooms, data = apartments)
explainer_rf <- explain(apartments_rf_model,
                        data = apartments_test[,2:5],
                        y = apartments_test$m2.price)

iBreakDown::break_down(explainer_rf, new_observation = apartments_test[1,2:5])
apartments_test[1,2:5]

This example shows wrong observation values in break_down object.

nice_format <- function(x) {

This formatting could be done in print and plot functions (if really needed), not in local_attributions (and probably round instead of signif).

@hbaniecki hbaniecki added the invalid ❕ This doesn't seem right label Nov 18, 2019
pbiecek pushed a commit that referenced this issue Dec 10, 2019
* undo observation value rounding

* Update local_attributions.R
@pbiecek
Copy link
Member

pbiecek commented Dec 10, 2019

Thanks!

@pbiecek pbiecek closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ❕ This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants