Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N = NULL in pdp/ale/cd returns error #134

Closed
hbaniecki opened this issue Nov 9, 2020 · 0 comments · Fixed by #133
Closed

N = NULL in pdp/ale/cd returns error #134

hbaniecki opened this issue Nov 9, 2020 · 0 comments · Fixed by #133
Labels
bug 💣 Bug to fix

Comments

@hbaniecki
Copy link
Member

There probably should be if (!is.null(N)) like in feature_importance

ingredients/R/accumulated_dependence.R

Line 108 in 91c9d39

if (N < nrow(data)) {

@hbaniecki hbaniecki added the bug 💣 Bug to fix label Nov 9, 2020
hbaniecki added a commit that referenced this issue Nov 9, 2020
@hbaniecki
potential fix for #134
64f75a7
@hbaniecki hbaniecki mentioned this issue Nov 9, 2020
Merged
pbiecek pushed a commit that referenced this issue Nov 12, 2020
@hbaniecki
code and doc maintenance (#133)
d87052a 
* code and doc maintenance

* potential fix for #134

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 💣 Bug to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

code and doc maintenance ModelOriented/ingredients
1 participant
@hbaniecki