New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Audio flyout is not shown when the volume is changed through means other than media keys #4
Comments
Still shows an old flyout. But if new flyout has been opened by pressing media key, it captures volume changes by touchpad Here's a video demo: https://lithi.io/file/B9rb.mp4 |
I think DUIHook doesn't get triggered properly, hmmm... What do you think @ShankarBUS ? |
The DUIHook can only notify the native UI's events. It can't detect which UI (i.e. brightness/audio, etc) is shown. Each helper must trigger on their own (with your implementation, the audio & brightness helpers are triggered by shell messages) and the FlyoutHandler will hide the native when the helper need to show UIs. DUIHook has nothing to do with triggering anything. DUIHook can be completely removed if the native UI is permanently hidden on start. It's only a safety measure to fallback to the native UI when the case couldn't be handled by our app (originally created as a fallback for brightness flyout). My guess is the shell hook messages are not received when the touchpad is used. (Even though it should be) Hey @Dubzer, are you 100% you used the latest build, can you recheck it with v0.3.0 release? |
@ShankarBUS I used the latest release version |
Ok, I managed to repro with your exact settings. The touchpad doesn't use shellhook. I'll see what I can do. |
Further digging: |
Also having this issue with a Bluetooth speaker on V0.4.1 (Microsoft Store) |
@oscargb1 |
Could anyone in our team or people in this thread verify if adb52c2 fixes this issue? |
Will do. |
Good to hear it should be fixed! |
Wicked! Is there a timeframe for when to expect the update? |
Within 2 weeks? |
A fix for this has been included in 0.9.X - Beta.1 |
While the main issue has been fixed by 0.9.3 there is a small bug #581 |
* Updated Greek Translation (#495) * Updated Greek Translation * Fixed Num Lock Flyout Out of Margins * Flyout animation toggle (#511) * widget animation toggle * translation added * Flyout animation toggle - done * minor changes * typo in ru translation * Update Russian translation (#510) * Update ModernFlyouts.ru.xlf * Update README.md * Update README.md * Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf * Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf * Apply suggestions from code review * - Updated Nuget Packages * Localized Manifest * Remove redundant playground * .wapproj simplification remove redundant windows.universal target * . * Update nuget packages * Update Nuget Packages * Minor cleanup * Finally! Fixed #4 - Bug: Audio flyout is not shown when the volume is changed through means other than media keys Fixed #470 - Bug: Flyouts doesn't appear while holding any mousebutton * fix null crash * Revert "fix null crash" This reverts commit 4ef6985. * Minor fixes * Translated all strings to danish (#516) * Fix issue template syntax error (#509) * Add some translators into the list in README (#505) * Updated translators list on README * Translated all strings to danish Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> * Temp enable both zh-hans and zh-cn * Update Ukrainian translation (#545) * Fix issue template syntax error (#509) * Add some translators into the list in README (#505) * Updated translators list on README * Update ModernFlyouts.uk.xlf * Update ModernFlyouts.uk.xlf * Update ModernFlyouts.uk.xlf very important commit) Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> Co-authored-by: Sam <35312698+Samuel12321@users.noreply.github.com> * Re-Updated Turkish Translation (#562) * Fix issue template syntax error (#509) * Add some translators into the list in README (#505) * Updated translators list on README * Re-Updated Turkish Translation * Re-Updated Turkish Translation v2 Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> * Fix syntax error for settings.off * updates Co-authored-by: Vasilis Patelis <65589110+VasilisPat@users.noreply.github.com> Co-authored-by: karpovv-boris <78983523+karpovv-boris@users.noreply.github.com> Co-authored-by: Tony <ANT0x1@users.noreply.github.com> Co-authored-by: sam <sam> Co-authored-by: Sam <samuelgilliessmith@hotmail.com> Co-authored-by: Shankar <shankarbus04082001@hotmail.com> Co-authored-by: Emil Nymann Sølyst <emilnymann96@gmail.com> Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> Co-authored-by: PlayDay <18056374+playday3008@users.noreply.github.com> Co-authored-by: Eren <75967441+ErenAKGUN2007@users.noreply.github.com>
This issue seems to still exist on Windows 11--is there anything I can do to help investigate & resolve this issue? |
Same here, I confirm I'm having this issue in Windows 11 |
Description of the bug :
The audio part of ModernFlyouts is not shown/triggered when the volume is changed through a knob/dial in a USB speaker or headphones (wireless or wired), it will only shown the corresponding media keys are pressed. The old flyout is shown in that case.
Expected Behavior :
The audio part of ModernFlyouts should be shown when the volume is also changed through means other than media keys
Additional context
Source - reddit comments :
The text was updated successfully, but these errors were encountered: