Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Audio flyout is not shown when the volume is changed through means other than media keys #4

Closed
ShankarBUS opened this issue Jul 12, 2020 · 51 comments · Fixed by #7
Assignees
Labels
Bug Something isn't working Enhancement New feature or request Fixed Has been fixed. Help Wanted Extra attention is needed High Priority
Projects

Comments

@ShankarBUS
Copy link
Member

ShankarBUS commented Jul 12, 2020

Description of the bug :

The audio part of ModernFlyouts is not shown/triggered when the volume is changed through a knob/dial in a USB speaker or headphones (wireless or wired), it will only shown the corresponding media keys are pressed. The old flyout is shown in that case.

Expected Behavior :
The audio part of ModernFlyouts should be shown when the volume is also changed through means other than media keys

Additional context
Source - reddit comments :

  1. "... One odd thing, if I use the volume keys on my keyboard, I get your volume control, but if I use the knob on my USB speaker I get the regular Windows one." - u/Froggypwns : source

  2. "Same here with my Surface Headphones dial. The modern flyout shows up with the keys, but not with the dial on my headphones. ..." - u/RealTeesh2257 : source

@ShankarBUS ShankarBUS added Bug Something isn't working Enhancement New feature or request labels Jul 12, 2020
@Dubzer
Copy link

Dubzer commented Jul 29, 2020

This also happens when change volume with touchpad. Mine supports precision driver, not sure if this a thing for others.

image

@ShankarBUS ShankarBUS pinned this issue Jul 29, 2020
@ADeltaX ADeltaX mentioned this issue Jul 29, 2020
@ShankarBUS ShankarBUS unpinned this issue Jul 30, 2020
@ShankarBUS ShankarBUS pinned this issue Jul 30, 2020
@ShankarBUS
Copy link
Member Author

ShankarBUS commented Jul 30, 2020

Hey @Dubzer, can you rebuild and test this app again to see if this issue persist with your touchpad? It should be solved by now due to the contribution from @ADeltaX. Can you please verify it?

@Dubzer
Copy link

Dubzer commented Jul 31, 2020

Still shows an old flyout. But if new flyout has been opened by pressing media key, it captures volume changes by touchpad

Here's a video demo: https://lithi.io/file/B9rb.mp4

@ADeltaX
Copy link
Member

ADeltaX commented Jul 31, 2020

I think DUIHook doesn't get triggered properly, hmmm...

What do you think @ShankarBUS ?

@ShankarBUS
Copy link
Member Author

ShankarBUS commented Jul 31, 2020

The DUIHook can only notify the native UI's events. It can't detect which UI (i.e. brightness/audio, etc) is shown. Each helper must trigger on their own (with your implementation, the audio & brightness helpers are triggered by shell messages) and the FlyoutHandler will hide the native when the helper need to show UIs. DUIHook has nothing to do with triggering anything. DUIHook can be completely removed if the native UI is permanently hidden on start. It's only a safety measure to fallback to the native UI when the case couldn't be handled by our app (originally created as a fallback for brightness flyout).

My guess is the shell hook messages are not received when the touchpad is used. (Even though it should be)

Hey @Dubzer, are you 100% you used the latest build, can you recheck it with v0.3.0 release?

@Dubzer
Copy link

Dubzer commented Jul 31, 2020

@ShankarBUS I used the latest release version

@ADeltaX
Copy link
Member

ADeltaX commented Jul 31, 2020

Ok, I managed to repro with your exact settings. The touchpad doesn't use shellhook.
In fact there is a tiny bug: if you set "play/pause" as touchpad click, it will toggle the play/pause but it will not show the UI at all. So even MS' one isn't reliable lol

I'll see what I can do.

@ShankarBUS ShankarBUS reopened this Jul 31, 2020
@ADeltaX
Copy link
Member

ADeltaX commented Aug 25, 2020

Further digging:
Touchpad scrolling (audio) is handled by "TouchpadVolumeGestureHandler" which will show the "HardwareButtonFlyout" directly with no "system" notifications (hint: twinui.dll). Basically it renders "impossible" to hook. For the moment I haven't found anything API/Interface that I can try to "talk" into.

@ShankarBUS ShankarBUS added this to To do in v1.0 via automation Sep 2, 2020
@ShankarBUS ShankarBUS unpinned this issue Sep 2, 2020
@ShankarBUS ShankarBUS pinned this issue Sep 2, 2020
@ottodoesntknow
Copy link

Also having this issue with a Bluetooth speaker on V0.4.1 (Microsoft Store)

@ShankarBUS
Copy link
Member Author

@oscargb1
Sorry for your inconvenience 😅. I will try my best to solve this issue. Be patient until this bug is fixed.

@Samuel12321 Samuel12321 added this to To do in 0.9.3 via automation Apr 8, 2021
@Samuel12321 Samuel12321 removed this from To do in v1.0 Apr 8, 2021
@Samuel12321 Samuel12321 moved this from To do to In progress in 0.9.3 Apr 8, 2021
ShankarBUS added a commit that referenced this issue Apr 8, 2021
Fixed #4 - Bug: Audio flyout is not shown when the volume is changed through means other than media keys
Fixed #470 - Bug: Flyouts doesn't appear while holding any mousebutton
@ShankarBUS
Copy link
Member Author

Could anyone in our team or people in this thread verify if adb52c2 fixes this issue?

@Samuel12321
Copy link
Member

Will do.

@Final-Hawk
Copy link

Good to hear it should be fixed!

@luximus-hunter
Copy link

Wicked! Is there a timeframe for when to expect the update?

@ShankarBUS
Copy link
Member Author

Within 2 weeks?

@Samuel12321
Copy link
Member

A fix for this has been included in 0.9.X - Beta.1

@Samuel12321
Copy link
Member

While the main issue has been fixed by 0.9.3 there is a small bug #581

0.9.3 automation moved this from In progress to Done Apr 22, 2021
Samuel12321 added a commit that referenced this issue Apr 22, 2021
* Updated Greek Translation (#495)

* Updated Greek Translation

* Fixed Num Lock Flyout Out of Margins

* Flyout animation toggle (#511)

* widget animation toggle

* translation added

* Flyout animation toggle - done

* minor changes

* typo in ru translation

* Update Russian translation (#510)

* Update ModernFlyouts.ru.xlf

* Update README.md

* Update README.md

* Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf

* Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf

* Apply suggestions from code review

* - Updated Nuget Packages

* Localized Manifest

* Remove redundant playground

* .wapproj simplification
remove redundant windows.universal target

* .

* Update nuget packages

* Update Nuget Packages

* Minor cleanup

* Finally!

Fixed #4 - Bug: Audio flyout is not shown when the volume is changed through means other than media keys
Fixed #470 - Bug: Flyouts doesn't appear while holding any mousebutton

* fix null crash

* Revert "fix null crash"

This reverts commit 4ef6985.

* Minor fixes

* Translated all strings to danish (#516)

* Fix issue template syntax error (#509)

* Add some translators into the list in README (#505)

* Updated translators list on README

* Translated all strings to danish

Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>

* Temp enable both zh-hans and zh-cn

* Update Ukrainian translation (#545)

* Fix issue template syntax error (#509)

* Add some translators into the list in README (#505)

* Updated translators list on README

* Update ModernFlyouts.uk.xlf

* Update ModernFlyouts.uk.xlf

* Update ModernFlyouts.uk.xlf

very important commit)

Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>
Co-authored-by: Sam <35312698+Samuel12321@users.noreply.github.com>

* Re-Updated Turkish Translation (#562)

* Fix issue template syntax error (#509)

* Add some translators into the list in README (#505)

* Updated translators list on README

* Re-Updated Turkish Translation

* Re-Updated Turkish Translation v2

Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>

* Fix syntax error for settings.off

* updates

Co-authored-by: Vasilis Patelis <65589110+VasilisPat@users.noreply.github.com>
Co-authored-by: karpovv-boris <78983523+karpovv-boris@users.noreply.github.com>
Co-authored-by: Tony <ANT0x1@users.noreply.github.com>
Co-authored-by: sam <sam>
Co-authored-by: Sam <samuelgilliessmith@hotmail.com>
Co-authored-by: Shankar <shankarbus04082001@hotmail.com>
Co-authored-by: Emil Nymann Sølyst <emilnymann96@gmail.com>
Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>
Co-authored-by: PlayDay <18056374+playday3008@users.noreply.github.com>
Co-authored-by: Eren <75967441+ErenAKGUN2007@users.noreply.github.com>
@prakharb5 prakharb5 unpinned this issue May 5, 2021
@prakharb5 prakharb5 added Fixed Has been fixed. and removed Fixed in next update labels May 24, 2021
@ShankarBUS ShankarBUS mentioned this issue Aug 3, 2021
@blueputty01
Copy link

This issue seems to still exist on Windows 11--is there anything I can do to help investigate & resolve this issue?

@ChristopheRoyer21
Copy link

Same here, I confirm I'm having this issue in Windows 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request Fixed Has been fixed. Help Wanted Extra attention is needed High Priority
Projects
No open projects
0.9.3
  
Done
Development

Successfully merging a pull request may close this issue.