Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout animation toggle #511

Merged
merged 6 commits into from
Mar 23, 2021
Merged

Flyout animation toggle #511

merged 6 commits into from
Mar 23, 2021

Conversation

karpovv-boris
Copy link
Contributor

@karpovv-boris karpovv-boris commented Mar 15, 2021 •
edited
Loading

  1. Added toggle for disabling Flyout animation.
  2. Russian translation updated.

@karpovv-boris
Copy link
Contributor Author

Result:
result

@karpovv-boris
Copy link
Contributor Author

karpovv-boris commented Mar 15, 2021 •
edited
Loading

It also was mention about performance. (#445)
Find this how-to:
https://docs.microsoft.com/en-us/dotnet/desktop/wpf/graphics-multimedia/how-to-improve-rendering-performance-by-caching-an-element?view=netframeworkdesktop-4.8

Not sure maybe it should be like this:
cache mode

And don't know how to measure it, although I haven't tried benchmark-dotnet

@Samuel12321
Copy link
Member

Thanks so much for your help @karpovv-boris , this has been added to the 0.9.2 release.
Will just get @ADeltaX or @ShankarBUS to review before merging.

@karpovv-boris
Copy link
Contributor Author

Glad to help.

@karpovv-boris
Copy link
Contributor Author

Please, use russian translation from this PR #510

@prakharb5 prakharb5 added Enhancement New feature or request UI/UX Related to appearance of the app and flyout. labels Mar 17, 2021
@Samuel12321 Samuel12321 linked an issue Mar 22, 2021 that may be closed by this pull request
Feature Request: Toggle option for disable animations #445
Closed
@Samuel12321 Samuel12321 changed the base branch from main to dev March 22, 2021 23:12
@Samuel12321 Samuel12321 merged commit 1614cf9 into ModernFlyouts-Community:dev Mar 23, 2021
@Samuel12321
Copy link
Member

Merged, Thankyou @karpovv-boris , this will be visible in 0.9.2

@oacoello
Copy link

Thank you for adding the animation toogle

@karpovv-boris
Copy link
Contributor Author

@oacoello you're welcome

Samuel12321 added a commit that referenced this pull request Apr 22, 2021
@Samuel12321 @VasilisPat
@karpovv-boris @ANT0x1 @ShankarBUS @emilnymann @myuki @imgradeone @playday3008 @insanolanbiri
Dev merge for 0.9.3 (#582)
024c7d6 
* Updated Greek Translation (#495)

* Updated Greek Translation

* Fixed Num Lock Flyout Out of Margins

* Flyout animation toggle (#511)

* widget animation toggle

* translation added

* Flyout animation toggle - done

* minor changes

* typo in ru translation

* Update Russian translation (#510)

* Update ModernFlyouts.ru.xlf

* Update README.md

* Update README.md

* Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf

* Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf

* Apply suggestions from code review

* - Updated Nuget Packages

* Localized Manifest

* Remove redundant playground

* .wapproj simplification
remove redundant windows.universal target

* .

* Update nuget packages

* Update Nuget Packages

* Minor cleanup

* Finally!

Fixed #4 - Bug: Audio flyout is not shown when the volume is changed through means other than media keys
Fixed #470 - Bug: Flyouts doesn't appear while holding any mousebutton

* fix null crash

* Revert "fix null crash"

This reverts commit 4ef6985.

* Minor fixes

* Translated all strings to danish (#516)

* Fix issue template syntax error (#509)

* Add some translators into the list in README (#505)

* Updated translators list on README

* Translated all strings to danish

Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>

* Temp enable both zh-hans and zh-cn

* Update Ukrainian translation (#545)

* Fix issue template syntax error (#509)

* Add some translators into the list in README (#505)

* Updated translators list on README

* Update ModernFlyouts.uk.xlf

* Update ModernFlyouts.uk.xlf

* Update ModernFlyouts.uk.xlf

very important commit)

Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>
Co-authored-by: Sam <35312698+Samuel12321@users.noreply.github.com>

* Re-Updated Turkish Translation (#562)

* Fix issue template syntax error (#509)

* Add some translators into the list in README (#505)

* Updated translators list on README

* Re-Updated Turkish Translation

* Re-Updated Turkish Translation v2

Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>

* Fix syntax error for settings.off

* updates

Co-authored-by: Vasilis Patelis <65589110+VasilisPat@users.noreply.github.com>
Co-authored-by: karpovv-boris <78983523+karpovv-boris@users.noreply.github.com>
Co-authored-by: Tony <ANT0x1@users.noreply.github.com>
Co-authored-by: sam <sam>
Co-authored-by: Sam <samuelgilliessmith@hotmail.com>
Co-authored-by: Shankar <shankarbus04082001@hotmail.com>
Co-authored-by: Emil Nymann Sølyst <emilnymann96@gmail.com>
Co-authored-by: Myuki <myuki@outlook.ie>
Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com>
Co-authored-by: PlayDay <18056374+playday3008@users.noreply.github.com>
Co-authored-by: Eren <75967441+ErenAKGUN2007@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADeltaX ADeltaX ADeltaX approved these changes

@ShankarBUS ShankarBUS Awaiting requested review from ShankarBUS

Assignees
No one assigned
Labels
Enhancement New feature or request UI/UX Related to appearance of the app and flyout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Toggle option for disable animations
5 participants
@karpovv-boris @Samuel12321 @oacoello @ADeltaX @prakharb5