Ensuring ES5 tests return Booleans

Modernizr · Nov 27, 2013 · 463c82e · 463c82e
1 parent 1fc6e04
commit 463c82e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/feature-detects/es5/array.js b/feature-detects/es5/array.js
@@ -18,7 +18,7 @@ Check if browser implements ECMAScript 5 Array per specification.
 */
 define(['Modernizr'], function (Modernizr) {
   Modernizr.addTest('es5array', function () {
-    return Array.prototype &&
+    return !!(Array.prototype &&
       Array.prototype.every &&
       Array.prototype.filter &&
       Array.prototype.forEach &&
@@ -28,6 +28,6 @@ define(['Modernizr'], function (Modernizr) {
       Array.prototype.some &&
       Array.prototype.reduce &&
       Array.prototype.reduceRight &&
-      Array.isArray;
+      Array.isArray);
   });
 });
diff --git a/feature-detects/es5/date.js b/feature-detects/es5/date.js
@@ -25,10 +25,10 @@ define(['Modernizr'], function (Modernizr) {
     } catch (e) {
       // no ISO date parsing yet
     }
-    return Date.now &&
+    return !!(Date.now &&
       Date.prototype &&
       Date.prototype.toISOString &&
       Date.prototype.toJSON &&
-      canParseISODate;
+      canParseISODate);
   });
 });
diff --git a/feature-detects/es5/function.js b/feature-detects/es5/function.js
@@ -18,6 +18,6 @@ Check if browser implements ECMAScript 5 Function per specification.
 */
 define(['Modernizr'], function (Modernizr) {
   Modernizr.addTest('es5function', function () {
-    return Function.prototype && Function.prototype.bind;
+    return !!(Function.prototype && Function.prototype.bind);
   });
 });
diff --git a/feature-detects/es5/object.js b/feature-detects/es5/object.js
@@ -18,7 +18,7 @@ Check if browser implements ECMAScript 5 Object per specification.
 */
 define(['Modernizr'], function (Modernizr) {
   Modernizr.addTest('es5object', function () {
-    return Object.keys &&
+    return !!(Object.keys &&
       Object.create &&
       Object.getPrototypeOf &&
       Object.getOwnPropertyNames &&
@@ -30,6 +30,6 @@ define(['Modernizr'], function (Modernizr) {
       Object.defineProperties &&
       Object.seal &&
       Object.freeze &&
-      Object.preventExtensions;
+      Object.preventExtensions);
   });
 });
diff --git a/feature-detects/es5/string.js b/feature-detects/es5/string.js
@@ -18,6 +18,6 @@ Check if browser implements ECMAScript 5 String per specification.
 */
 define(['Modernizr'], function (Modernizr) {
   Modernizr.addTest('es5string', function () {
-    return String.prototype && String.prototype.trim;
+    return !!(String.prototype && String.prototype.trim);
   });
 });