-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added extended support of prefixed method to test DOM properties too
- Loading branch information
1 parent
0f7885b
commit 537a762
Showing
3 changed files
with
60 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -436,17 +436,28 @@ test('Modernizr.testAllProps()',function(){ | |
test('Modernizr.prefixed()', function(){ | ||
// https://gist.github.com/523692 | ||
|
||
function gimmePrefix(prop){ | ||
function gimmePrefix(prop, obj){ | ||
var prefixes = ['Moz','Khtml','Webkit','O','ms'], | ||
domPrefixes = ['moz','khtml','webkit','o','ms'], | ||
elem = document.createElement('div'), | ||
upper = prop.charAt(0).toUpperCase() + prop.slice(1); | ||
|
||
if (prop in elem.style) | ||
return prop; | ||
if(!obj) { | ||
if (prop in elem.style) | ||
return prop; | ||
|
||
for (var len = prefixes.length; len--; ){ | ||
if ((prefixes[len] + upper) in elem.style) | ||
return (prefixes[len] + upper); | ||
for (var len = prefixes.length; len--; ){ | ||
if ((prefixes[len] + upper) in elem.style) | ||
return (prefixes[len] + upper); | ||
} | ||
} else { | ||
if (prop in obj) | ||
return prop; | ||
|
||
for (var len = domPrefixes.length; len--; ){ | ||
if ((domPrefixes[len] + upper) in obj) | ||
return (domPrefixes[len] + upper); | ||
} | ||
} | ||
|
||
|
||
|
@@ -456,11 +467,21 @@ test('Modernizr.prefixed()', function(){ | |
var propArr = ['transition', 'backgroundSize', 'boxSizing', 'borderImage', | ||
'borderRadius', 'boxShadow', 'columnCount']; | ||
|
||
|
||
var domPropArr = [{ 'prop': 'requestAnimationFrame', 'obj': window }, | ||
{ 'prop': 'querySelectorAll', 'obj': document }, | ||
{ 'prop': 'matchesSelector', 'obj': document.createElement('div') }]; | ||
|
||
for (var i = -1, len = propArr.length; ++i < len; ){ | ||
var prop = propArr[i]; | ||
equals( Modernizr.prefixed(prop), gimmePrefix(prop), 'results for ' + prop + ' match the homebaked prefix finder'); | ||
} | ||
|
||
for (var i = -1, len = domPropArr.length; ++i < len; ){ | ||
var prop = domPropArr[i]; | ||
console.log(Modernizr.prefixed(prop.prop, prop.obj),gimmePrefix(prop.prop, prop.obj)); | ||
This comment has been minimized.
Sorry, something went wrong.
aFarkas
Member
|
||
equals( Modernizr.prefixed(prop.prop, prop.obj), gimmePrefix(prop.prop, prop.obj), 'results for ' + prop.prop + ' match the homebaked prefix finder'); | ||
} | ||
|
||
|
||
|
||
|
||
|
btw. you checked this in ;)