Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style element left in <head> after tests['fontface'] executes #141

Closed
jkappers opened this issue Nov 9, 2010 · 1 comment
Closed

Style element left in <head> after tests['fontface'] executes #141

jkappers opened this issue Nov 9, 2010 · 1 comment

Comments

@jkappers
Copy link

jkappers commented Nov 9, 2010

I found this in the 'fontface' test:

    // removing it crashes IE browsers
    //head.removeChild(style);

IE dies when the return statement runs the supportAtRule function:

    var supportAtRule = impl.hasFeature('CSS2', '') ?
            function(rule) { ... } :
            function(rule) {
                if (!(sheet && rule)) return false;
                sheet.cssText = rule; //<-- IE DIES HERE IF STYLE REMOVED

                return sheet.cssText.length !== 0 && !(/unknown/i).test(sheet.cssText) &&
                  sheet.cssText
                        .replace(/\r+|\n+/g, '')
                        .indexOf(rule.split(' ')[0]) === 0;
            };

Seems to work okay when I do this:

    var result = supportAtRule('@font-face { font-family: "font"; src: "font.ttf"; }');
    head.removeChild(style);
    return result;
@paulirish
Copy link
Member

remove extra style element from head. closed by 09fe568

paulirish added a commit to SlexAxton/Modernizr that referenced this issue May 26, 2011
@paulirish
remove extra style element from head. fixes Modernizr#141
09fe568
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
@paulirish
remove extra style element from head. fixes Modernizr#141
97954de
@Tshegofatso Tshegofatso mentioned this issue Nov 27, 2023
Open
@Tshegofatso Tshegofatso mentioned this issue May 13, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @jkappers