-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flash detection throws an error in IE #1432
Comments
Hey @Aaike! Would you be able to share your code? |
I just forked it and added a test : If i check that in IE it throws the error. The build was created by cloning the master branch and simply do the grunt build, without any changes to any files. The error also happens with the unminified file, which is also in the build_test directory. |
So... by doing the "fix" i mentioned earlier i no longer have errors in IE 9 and 10 related to the flash test. Which seems to come from the feature-detects\img\webp.js at line 66 If i remove the webp test from the build then i have a build file that doesn't throw any errors in IE8-10 ps: These tests don't really matter to me so i just excluded them, i am good to go , just reporting the errors :) |
I also get this error when running test file which @Aaike provided. You need to have Flash installed on your browser to get this error. |
fixes Modernizr#1413, also fixes Modernizr#1432
fixes Modernizr#1413, also fixes Modernizr#1432
The feature-detect/flash.js script throws an error in all version of IE.
this happens at lin 82 :
if (body.fake) {
body.parentNode.removeChild(body);
}
the error is : SCRIPT5007: Unable to get property 'removeChild' of undefined or null reference
this happens because the parentNode property is empty.
i've 'fixed' this in my local version like this :
if (body.fake && body.parentNode) {
body.parentNode.removeChild(body);
}
Although i think this is not the correct way to actually fix it...
just wanted to report the error and see if anybody knows how to correctly fix this issue.
ps: this is on the master branch
The text was updated successfully, but these errors were encountered: