Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizr (requirejs?) windows bug #1523

Closed
dmzkrsk opened this issue Feb 11, 2015 · 10 comments
Closed

Modernizr (requirejs?) windows bug #1523

dmzkrsk opened this issue Feb 11, 2015 · 10 comments

Comments

@dmzkrsk
Copy link

dmzkrsk commented Feb 11, 2015

I use modernizr 3.0.0-alpha in my gulp task (via gulp-modernizr) and it fails with error

Error: Tried loading "src/generate.js" at src/generate.js then tried node's require("src/generate.js") and it failed with error: Error: Cannot find module 'src/generate.js'
    at R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:2552:27
    at Object.context.execCb (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:1916:33)
    at Object.Module.check (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:1125:51)
    at Object.Module.enable (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:1409:22)
    at Object.context.enable (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:1777:39)
    at Function.req.get (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:2476:33)
    at Object.localRequire [as require] (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:1650:40)
    at requirejs (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\node_modules\requirejs\bin\r.js:2003:24)
    at Object.<anonymous> (R:\Dev\django-stage\md-bug\node_modules\gulp-modernizr\node_modules\customizr\node_modules\modernizr\lib\build.js:123:18)
    at Module._compile (module.js:456:26)

This line causes an error:

var generate = requirejs(__dirname + '/../src/generate.js');

I checked, that the path exists.

The line before

var generateBanner = requirejs(__dirname + '/generate-banner.js');

has no problem

I reproduced this bug on clean install with

npm install --save-dev gulp gulp-modernizr

and gulpfile.js:

var gulp       = require('gulp');
var modernizr  = require('gulp-modernizr');

gulp.task('default', function() {
    return gulp.src('*.js')
        .pipe(modernizr())
});
> grunt
@dmzkrsk dmzkrsk changed the title Modernizr requirejs windows bu Modernizr (requirejs?) windows bug Feb 11, 2015
@dmzkrsk
Copy link
Author

dmzkrsk commented Feb 11, 2015

I use Win8.1 x64 node==0.10.28

@patrickkettner
Copy link
Member

I will check it out as soon as I can get a windows machine, in the mean time could you try changing it to

var generate = requirejs('generate.js');

@dmzkrsk
Copy link
Author

dmzkrsk commented Feb 12, 2015

Didn't help. I also tracked down the issue in requirejs code, posted on their issue tracker requirejs/r.js#779

@dmzkrsk
Copy link
Author

dmzkrsk commented Feb 12, 2015

A hackish solution that worked

var generate = requirejs(__dirname.replace(/\\/g, '/') + '/../src/generate.js');

@patrickkettner
Copy link
Member

sorry, I meant to try

var generate = requirejs('generate');

src is the default path, and it should already be registered. I believe adding the .js extension makes it look for it in file mode, rather than by name

@dmzkrsk
Copy link
Author

dmzkrsk commented Feb 12, 2015

Yep, that worked

@patrickkettner
Copy link
Member

strangly, I just tried running on a windows 7 machine, and it worked without any modifications.

@patrickkettner
Copy link
Member

great, I will make that change momentarily

@JonCognioDigital
Copy link

I am still getting this problem with gulp-modernizr. Is that because the gulp plugin isn't using the latest version with the fix committed above?

@patrickkettner
Copy link
Member

yep. someone else randomly registered the package, before it was supposed to be public. its prerelease software, and so we are not version bumping on commits like we would otherwise. you will need to manually override it with master if you need to use it

patrickkettner added a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants