some tests crash when run within an iframe

[rozek]

Hello,

I just ran across two problems, where Modernizr tests crashed when run within an iframe. The fixes are trivial, how can I contribute them? Do you have an "official workflow"? (e.g., create new branch from master, fix in that branch, issue pull request - but who will then review that request and finally merge?)

Thanks in advance for any help!

With greetings from Germany,

Andreas Rozek

[patrickkettner]

Preform the PR as your mentioned and I will review and merge

…

On Jan 18, 2018 11:21 PM, "Andreas Rozek" ***@***.***> wrote: Hello, I just ran across two problems, where Modernizr tests crashed when run within an iframe. The fixes are trivial, how can I contribute them? Do you have an "official workflow"? (e.g., create new branch from master, fix in that branch, issue pull request - but who will then review that request and finally merge?) Thanks in advance for any help! With greetings from Germany, Andreas Rozek — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2280>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcaBuEfvlVF2K_xi6RClGdrvcmTiNQLks5tMEJugaJpZM4RkFES> .

[rozek]

Perfect, thank you!

(will take a moment - I'm currently having problems uploading my branch (authentication failure) and do not find a way to create a branch using the GitHub web UI)

[rozek]

Sorry for bothering you but...

...I do not seem to have the permission to create a new branch from master or publish a branch I created in my clone of your repository. Am I missing s.th.?

[patrickkettner]

Please push to a fork of the repo

…

On Jan 19, 2018 12:30 AM, "Andreas Rozek" ***@***.***> wrote: Sorry for bothering you but... ...I do not seem to have the permission to create a new branch from master or publish a branch I created in my clone of your repository. Am I missing s.th.? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2280 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcaBvCyda4lcee1-rpZ1ON0cB1I-bSCks5tMFKzgaJpZM4RkFES> .

[rozek]

Thanks for the hint, using forks rather than branches was new for me, sorry.

I did as instructed and started the PR - if you have any complaints, don't hesitate to contact me (it's my very first contribution to a GitHub project)