Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canvas.toDataURL tests improvement #802

Closed
jedierikb opened this issue Feb 6, 2013 · 2 comments
Closed

canvas.toDataURL tests improvement #802

jedierikb opened this issue Feb 6, 2013 · 2 comments

Comments

@jedierikb
Copy link
Contributor

Does this test need to load base64 image data before performing its test? Why not just serialize a square or... a blank canvas? Changing this would remove the inherent problems with the asynchronous nature of the test.

If this change sounds good, we can prepare an alternative for pulling in.

some of my original notes on the issue are here:
#470 (comment)
@paulirish
Copy link
Member

sounds good. can you prepare a PR/?

@jedierikb
Copy link
Contributor Author

will do.

@jedierikb jedierikb mentioned this issue Mar 11, 2013
Merged
@stucox stucox closed this as completed in d60a462 Mar 12, 2013
@stucox stucox mentioned this issue Mar 2, 2014
Closed
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
Merge pull request Modernizr#851 from jedierikb/master
121831b 
remove base64 data from canvastodataurl test, fixes Modernizr#802
@snyk-bot snyk-bot mentioned this issue May 10, 2022
Open
@cooljl31 cooljl31 mentioned this issue May 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulirish @jedierikb @stucox