canvas.toDataURL tests improvement #802

Closed
jedierikb opened this Issue Feb 6, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@jedierikb
Contributor

jedierikb commented Feb 6, 2013

Does this test need to load base64 image data before performing its test? Why not just serialize a square or... a blank canvas? Changing this would remove the inherent problems with the asynchronous nature of the test.

If this change sounds good, we can prepare an alternative for pulling in.

some of my original notes on the issue are here:
#470 (comment)

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Feb 25, 2013

Member

sounds good. can you prepare a PR/?

Member

paulirish commented Feb 25, 2013

sounds good. can you prepare a PR/?

@jedierikb

This comment has been minimized.

Show comment
Hide comment
@jedierikb

jedierikb Feb 26, 2013

Contributor

will do.

Contributor

jedierikb commented Feb 26, 2013

will do.

@stucox stucox closed this in d60a462 Mar 12, 2013

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Stu Cox
Merge pull request #851 from jedierikb/master
remove base64 data from canvastodataurl test, fixes #802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment