-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'transform-style: preserve-3d' test - fixes #762 #999
Conversation
I was unsure of when #933 would land is it's 2 months old and has a lot of commits which is why I did it without |
And please add a |
ping @edmellum |
@edmellum can you update the PR? if not, let us know so someone else can take ownership. |
Just updated to use |
Is this enough? Have you actually tested it? I don't have IE 10-11 near me, but I've set up a testing page: With detection as in your PR: Modernizr.addTest('preserve3d', Modernizr.testAllProps('transformStyle', 'preserve-3d')); And linked it to a few people with IE 10 & 11, and they are all reporting false positive results. The test reports |
I can confirm a false positive on ie 10 and 11. |
That fiddle uses Modernizr 2.6.2, which doesn't have the v3 API changes to This one does (with a minimal v3.0 build injected), and is |
So LGTM 👍 if everyone else agrees? |
@stucox awesome! :) What's the ETA for v3? |
Tested it a bit myself just now and it still looks good to me. |
Add 'transform-style: preserve-3d' test - fixes #762
Add 'transform-style: preserve-3d' test - fixes Modernizr#762
IE10 doesn't support
transform-style: preserve-3d
but does support 3D transforms. More info at #762.