Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'transform-style: preserve-3d' test - fixes #762 #999

Merged
merged 1 commit into from
Nov 6, 2013

Conversation

edmellum
Copy link
Contributor

IE10 doesn't support transform-style: preserve-3d but does support 3D transforms. More info at #762.

@stucox
Copy link
Member

stucox commented Jul 18, 2013

As I said in #762, I'd rather do this with testAllProps('transformStyle', 'preserve-3d'), once we've landed PR #933.

@edmellum
Copy link
Contributor Author

I was unsure of when #933 would land is it's 2 months old and has a lot of commits which is why I did it without testAllProps. I'll just refactor this PR once it lands. 😃

@stucox
Copy link
Member

stucox commented Aug 1, 2013

#933 is in master now – can you update your detect to use testAllProps() as I described above @edmellum?

@stucox
Copy link
Member

stucox commented Aug 1, 2013

And please add a /* DOC */ comment block.

@stucox
Copy link
Member

stucox commented Sep 14, 2013

ping @edmellum

@paulirish
Copy link
Member

@edmellum can you update the PR? if not, let us know so someone else can take ownership.

@edmellum
Copy link
Contributor Author

Just updated to use testAllProps() and /* DOC */ blocks. Sorry this took so long, lost track of the PR.

@darsain
Copy link

darsain commented Nov 2, 2013

Is this enough? Have you actually tested it? I don't have IE 10-11 near me, but I've set up a testing page:

http://jsfiddle.net/kjKLW/

With detection as in your PR:

Modernizr.addTest('preserve3d', Modernizr.testAllProps('transformStyle', 'preserve-3d'));

And linked it to a few people with IE 10 & 11, and they are all reporting false positive results. The test reports true when it should be false.

@patrickkettner
Copy link
Member

I can confirm a false positive on ie 10 and 11.
looks like a sniff test isn't enough.

@stucox
Copy link
Member

stucox commented Nov 3, 2013

That fiddle uses Modernizr 2.6.2, which doesn't have the v3 API changes to Modernizr.testAllProps() we have on master which are required to make this work.

This one does (with a minimal v3.0 build injected), and is true in Chrome 30 and false in IE10/11.

@stucox
Copy link
Member

stucox commented Nov 3, 2013

So LGTM 👍 if everyone else agrees?

@darsain
Copy link

darsain commented Nov 3, 2013

@stucox awesome! :) What's the ETA for v3?

@edmellum
Copy link
Contributor Author

edmellum commented Nov 3, 2013

Tested it a bit myself just now and it still looks good to me.

@patrickkettner
Copy link
Member

Beh, sorry @stucox. Should have looked at that.
@darsain there isn't one at the moment, there are a few things with the website that have been holding up the release

paulirish added a commit that referenced this pull request Nov 6, 2013
Add 'transform-style: preserve-3d' test - fixes #762
@paulirish paulirish merged commit 4c8f890 into Modernizr:master Nov 6, 2013
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Add 'transform-style: preserve-3d' test - fixes Modernizr#762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants