Fixing a scoping issue with multiple Modernizr.on() callbacks for a single test
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. |
SlexAxton
added a commit
that referenced
this pull request
Aug 13, 2013
Fixing a scoping issue with multiple `Modernizr.on()` callbacks for a single test
| @@ -35,14 +35,14 @@ define(['ModernizrProto', 'Modernizr', 'hasOwnProp', 'setClasses'], function( Mo | |||
| var cb; | |||
| var i; | |||
There was a problem hiding this comment.
Yeah, good spot. Fixed on master.
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Fixing a scoping issue with multiple `Modernizr.on()` callbacks for a single test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a scoping issue in
src/addTest.js:If there are multiple callbacks for a test, the value of
cbin this scope will be changed to the 2nd (then 3rd, then 4th etc) callback before the deferred function is executed even once – so the last callback gets executed multiple times, rather than each callback being called.This PR fixes this.
+@SlexAxton