Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the Shapes test to use shape-outside rather than shape-inside #1086

Merged
merged 1 commit into from
Oct 29, 2013

Conversation

zhorvath
Copy link
Contributor

Shapes Level 1 specification contains only shape-outside. I modified the test to be aligned with the specification.
From now the Shape test of Modernizr uses the shape-outside property for testing the feature. The following versions of the Shapes specification will contain support for shape-inside property.

…the test to be aligned with the specification.

From now the Shape test of Modernizr uses the shape-outside property for testing the feature. The following versions
of the Shapes specification will contain support for shape-inside property.
@zhorvath
Copy link
Contributor Author

review? @stucox @paulirish

@patrickkettner
Copy link
Member

Hey Zoltan! Thanks for the pull

Do you know which browsers only support level 1?

@zhorvath
Copy link
Contributor Author

Hi Patrick,

For Level 1, CSS Shapes can be applied to floats. (Level one is only about shape-outside.)
Level 1 will be the released version in Safari/Chrome/Opera. The experimental browsers (SafariNightly, Chrome Canary) support more features (like shape-inside) based on the previous Exclusions specification. Since Exclusions spec has been split up to Shapes and Exlusions, now the Shapes level 1 includes shape-outside only, thus that's gonna be shipped only in the first round.

@patrickkettner
Copy link
Member

ah, got it. Seems like a reasonable change, since we haven't rolled out the test outside master.

Since you are embedded with the spec, do you have any idea on what sort of a timeframe between level 1 and level 2 shipping to top browsers? 12 week, 2 years, etc.

My only concern would be if chrome/opera ships level 2 really quickly (relatively speaking), but safari doesn't for another year or so after that, peoples perception of what cssshapes means could be warped (see #1048 for a similar case).

@nimbupani
Copy link

@patrickkettner So there is a detailed table that tracks browser support for shapes. Right now I think we are on track to having implementations thoroughly match Shapes Level 1 in Blink & WebKit (by extension Chrome, Opera & Safari).

If it happens that Shapes Level 2 ships quickly (I think this is not very likely given the ambiguity around certain interactions), then I think we should expand 'support' to mean both shape-inside and shape-outside. I think we should definitely revisit when we face this issue, but at this point I think it shouldn't deter the basic detection mechanisms.

@astearns
Copy link

I agree with nimbupani - it will be a while before shapes level 2 progresses, at least as I've currently defined the next level. For now, it will be most useful just to detect support for shape-outside.

patrickkettner added a commit that referenced this pull request Oct 29, 2013
Modify the Shapes test to use shape-outside rather than shape-inside
@patrickkettner patrickkettner merged commit ee7fb07 into Modernizr:master Oct 29, 2013
@patrickkettner
Copy link
Member

Thanks guys!

patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Modify the Shapes test to use shape-outside rather than shape-inside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants