-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add srcset test #1105
add srcset test #1105
Conversation
|
||
*/ | ||
define(['Modernizr', 'createElement'], function( Modernizr, createElement ) { | ||
Modernizr.addTest('srcset', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really necessary to use a function just pass the boolean to addTest
Modernizr.addTest('srcset', 'srcset' in createElement('img'));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pft, wtf is this.
thanks for catching that
Fwiw |
Sorry, that was too presumptive of me to say without being more embedded with the RICG. My point was more that until a browser ships, or announces an intent-to-ship of the src-N is being implemented by firefox and blink, and webkit already has srcset. Therefore, we should have tests for these. Thank you very much for correcting me, however. I really don't want to be the source of misinformation. |
Yeah, it's actually a very late development so you'd have to be following it day-to-day to know where that whole mess had gotten to. src-N was called an abomination against all that's holy or something similar by webkit and that put the brakes on it (blink won't implement without webkit doing so as well). Much table-flipping happened and people went back to the drawing board. Improbably |
where has blink said they wouldn't implement src-n without webkit doing so? |
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2013-November/041397.html |
well snap. hot drama, indeed. |
add srcset test
fixes #661,
since<picture>
seems to be being abandoned.~edit: struck out unnecessary speculative information.