Add querySelector test, addresses #1194

[triblondon]

Wasn't sure whether document should be an injected dependency, but the convention seems to be to assume it's a global, so have followed that.

[stucox]

Thanks Andrew.

We have a module for document.documentElement, but not document… so assuming global is fine I think.

Dumb questions:

• I take it we’re assuming this also implies querySelectorAll() support
• Any polyfills we should mention? We can define them in lib/polyfills.json then attach them via the polyfills metadata attribute
• Any documentation we could link to via the notes metadata attribute? e.g. W3C/WHATWG specs or MDN docs

[triblondon]

I take it we’re assuming this also implies querySelectorAll() support

Yes. I know of now implementations that don't implement both, but happy to AND the two checks.

Any polyfills we should mention? We can define them in lib/polyfills.json then attach them via the polyfills metadata attribute

I found https://github.com/termi/CSS_selector_engine. To be honest I'm more concerned about declaring requirements in terms of Modernizr tests than providing means of satisfying them, but from a quick search this seems reasonable.

Any documentation we could link to via the notes metadata attribute? e.g. W3C/WHATWG specs or MDN docs

A quick search suggests http://www.w3.org/TR/selectors-api/#queryselectorall, but I'm not sure if that's the canonical spec.

[triblondon]

I've addressed the docs and additional property test. Haven't added the polyfill - let me know if you need that and if @termi's one is the right one to use.

[stucox]

To be honest I'm more concerned about declaring requirements in terms of Modernizr tests than providing means of satisfying them

Me too, generally – I’d probably use jQuery instead of polyfilling querySelector or just avoid it altogether when not supported – but we’re trying to keep the metadata as complete as possible. Yep, just spotted @termi’s is the one we have on our polyfill wiki page so yeah I think it’d be a good one to mention.

[termi]

Hi all! I'm not working on my querySelector Polyfill throughout the year, but I can go back to work on it. Right now I need a feedback: that is good and that need to be improved.

[triblondon]

Are you happy to accept this now, @stucox?

[stucox]

👍

Cheers!