Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping call to indexeddb.deleteDatabase in a try…catch #1258

Merged
merged 1 commit into from
Mar 12, 2014

Conversation

stucox
Copy link
Member

@stucox stucox commented Mar 12, 2014

Wrapping call to indexeddb.deleteDatabase in a try…catch because it errors in some contexts (e.g. data URIs).

@patrickkettner
Copy link
Member

howd you find this un?

@stucox
Copy link
Member Author

stucox commented Mar 12, 2014

All the cool kids these days do their hacking on data:text/html, don’t ya know.

Handy bookmark for hacking around with Modernizr (unfortunately the number changes every time I create a new build from master):

data:text/html,<script src="https://rawgithub.com/stucox/7707684/raw/2c3fb25595ced23301aa7276dd739027eef76e64/modernizr-3.0-beta.all.js"></script>

@patrickkettner
Copy link
Member

neato

try this to automate that a bit
grunt && gist dist/modernizr-build.min.js -p -d "Beta version of Modernizr 3.0, with everything in, built from commit $(git rev-parse --short HEAD)" | awk -F/ '{print "data:text/html,<script src=\"http://rawgithub.com/stucox/"$4"/raw/modernizr-build.min.js\"></script>"}' | pbcopy

@patrickkettner
Copy link
Member

can't hurt, but I don' see this affecting anyone but us

+1

patrickkettner added a commit that referenced this pull request Mar 12, 2014
Wrapping call to `indexeddb.deleteDatabase` in a try…catch
@patrickkettner patrickkettner merged commit d18105e into Modernizr:master Mar 12, 2014
@stucox
Copy link
Member Author

stucox commented Mar 12, 2014

That’s some ninja GitHub foo right there. Will give it a go.

patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Wrapping call to `indexeddb.deleteDatabase` in a try…catch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants