Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .npmignore save 2.5mb when publishing #1277

Merged
merged 1 commit into from
Mar 28, 2014

Conversation

thanpolas
Copy link
Contributor

No description provided.

@ryanseddon
Copy link
Member

We don't publish to npm because of the nature of the project being a builder system.

@thanpolas
Copy link
Contributor Author

but there are plans to publish, no?

@patrickkettner
Copy link
Member

@patrickkettner
Copy link
Member

We still need Gruntfile.js, as that is the most common use case for building modernizr. test would be required as a result of that. great catch on media, though!

@thanpolas
Copy link
Contributor Author

no you don't

@patrickkettner
Copy link
Member

yes, we do.

@ryanseddon
Copy link
Member

Ah my bad.

@thanpolas
Copy link
Contributor Author

Modernizr will be published on NPM with a singular purpose, to provide a build API to node applications.

Please explain why Gruntfile.js is required in the NPM Package and what are the expected use cases for it when distributed.

@stucox
Copy link
Member

stucox commented Mar 26, 2014

Please explain why Gruntfile.js is required in the NPM Package and what are the expected use cases for it when distributed.

Because Grunt is currently a dependency for building Modernizr. It’d be nice if it wasn’t, but at the moment it is.

Create .npmignore save 2.5mb when publishing

Modernizr lib depends on Grunt Actual
@thanpolas
Copy link
Contributor Author

oh... just saw that, sexy!

Removed Gruntfile.js and squashed

@stucox
Copy link
Member

stucox commented Mar 26, 2014

So we don’t need the test/ dir (to build)… but telling NPM to ignore this would mean it would grab a folder with a Gruntfile for which only some of the tasks actually worked. Is this a bit odd?

I agree that the point of publishing Modernizr to NPM would simply be to expose a build API though, so personally I’d be happy with this… @patrickkettner @ryanseddon ?

@patrickkettner
Copy link
Member

sgtm

@ryanseddon
Copy link
Member

yep all good

stucox pushed a commit that referenced this pull request Mar 28, 2014
Create .npmignore save 2.5mb when publishing
@stucox stucox merged commit 3835ecb into Modernizr:master Mar 28, 2014
@stucox
Copy link
Member

stucox commented Mar 28, 2014

👍 cheers @thanpolas

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Create .npmignore save 2.5mb when publishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants