Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove speechinput test #1326

Merged
merged 1 commit into from
May 1, 2014
Merged

Remove speechinput test #1326

merged 1 commit into from
May 1, 2014

Conversation

alrra
Copy link
Contributor

@alrra alrra commented May 1, 2014

`x-webkit-speech` is already disabled in the last Chrome Canary,
and it will soon be completely removed from from Chrome.

Ref: https://code.google.com/p/chromium/issues/detail?id=223198
     https://code.google.com/p/chromium/issues/detail?id=360448
@patrickkettner
Copy link
Member

Chrome was the only thing that ever shipped this, right?

On Thu, May 1, 2014 at 5:42 PM, Cătălin Mariș notifications@github.com
wrote:

x-webkit-speech is already disabled in the last Chrome Canary:
screen shot 2014-05-02 at 00 29 17
and it will soon be completely remove from from Chrome:

@alrra
Copy link
Contributor Author

alrra commented May 1, 2014

Chrome was the only thing that ever shipped this, right?

@patrickkettner yes, from http://src.chromium.org/viewvc/blink?view=revision&revision=171187:

x-webkit-speech is a Chrome-only feature which was announced as deprecated Feb 2014:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jlPdpx6jErE

@patrickkettner
Copy link
Member

Beautiful PR, as usual @alrra

patrickkettner added a commit that referenced this pull request May 1, 2014
@patrickkettner patrickkettner merged commit 744676c into Modernizr:master May 1, 2014
@alrra alrra deleted the remove-speechinput-test branch May 1, 2014 22:06
@alrra
Copy link
Contributor Author

alrra commented May 1, 2014

Also, x-webkit-speech doesn't work in the current stable Chrome for Android (and if I remember correctly, it never did):

@patrickkettner
Copy link
Member

Stop sellin, you sold me :)

Already merged.

On Thu, May 1, 2014 at 6:24 PM, Cătălin Mariș notifications@github.com
wrote:

Also, x-webkit-speech doesn't work in the current stable Chrome for Android (and if I remember correctly, it never did):


Reply to this email directly or view it on GitHub:
#1326 (comment)

@alrra
Copy link
Contributor Author

alrra commented May 1, 2014

Stop sellin, you sold me :)

haha

Already merged.

@patrickkettner yeah I know, but I thought it would be nice to also have that information here [:

@patrickkettner
Copy link
Member

I figured, just teasing :]

patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants