Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new html5shiv #1343

Merged
merged 2 commits into from
Jun 14, 2014

Conversation

jmartin84
Copy link
Contributor

Fixes #1335

@@ -1,309 +1,322 @@
define(function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just dropped a whole new file in, was that line part of modernizr or the shiv itself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a part of our build, still needed it unfortunately :[

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, my fault, I'll take a look at it then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks mang

@patrickkettner
Copy link
Member

Hey @jmartin84 - thanks for the PR! Not really clear on why you formatted it the way your did, could you comment?

thanks again!

patrickkettner added a commit that referenced this pull request Jun 14, 2014
@patrickkettner patrickkettner merged commit 385097f into Modernizr:master Jun 14, 2014
@jmartin84 jmartin84 deleted the updated-html5shiv-1335 branch June 14, 2014 16:11
patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update html5shiv to 3.7.2
2 participants