Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #1362

Merged
merged 1 commit into from
Jun 7, 2014
Merged

Update readme.md #1362

merged 1 commit into from
Jun 7, 2014

Conversation

frob
Copy link
Contributor

@frob frob commented Jun 7, 2014

Include the step to install grunt dependencies before attempting the build

Making edits from
#1361

Include the step to install grunt dependencies before attempting the build
@patrickkettner patrickkettner mentioned this pull request Jun 7, 2014
@patrickkettner
Copy link
Member

Thanks again @frob! ProTip: You can git push --force, rather than a new PR, since you are the only one touching that part of the code its kosher (as opposed to force pushing into a master branch or branch that others have been working in).

patrickkettner added a commit that referenced this pull request Jun 7, 2014
@patrickkettner patrickkettner merged commit 2613888 into Modernizr:master Jun 7, 2014
@frob
Copy link
Contributor Author

frob commented Jun 7, 2014

Thanks for the tip. I was doing this all in the gihub ui rather on my computer to save time while at the airport. I couldn't figure out how to do it on the site.

@patrickkettner
Copy link
Member

ah, you can't :]

thanks again for contributing! Very much appreciated. Enjoy your trip! :D

@zhanghaihua
Copy link

good

发自我的网易邮箱手机智能版

在 2014-06-08 03:57:25,"Frank Anderson" notifications@github.com 写道:

Include the step to install grunt dependencies before attempting the build

Making edits from
#1361

You can merge this Pull Request by running
git pull https://github.com/frob/Modernizr master

Or view, comment on, or merge it at:

#1362

Commit Summary
Update readme.md
File Changes
Mreadme.md (1)
Patch Links:
https://github.com/Modernizr/Modernizr/pull/1362.patch
https://github.com/Modernizr/Modernizr/pull/1362.diff


Reply to this email directly or view it on GitHub.

@patrickkettner
Copy link
Member

amen to that, @zhanghaihua. Its easy to forget the small things when you do them often, so this sort of PR is incredibly helpful. Thanks again, @frob!

patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants