use exec rather than spawn when using windows #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work as |
|
you are a beautiful man, @sindresorhus |
fixes Modernizr#1290 this gives us the least terrible of both worlds, using spawn unless windows, where we use exec. That way everyone can build
patrickkettner
added a commit
that referenced
this pull request
Jun 17, 2014
use exec rather than spawn when using windows
patrickkettner
added a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
use exec rather than spawn when using windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1290
this gives us the least terrible of both worlds, using spawn unlesswindows, where we use exec. That way everyone can build
uses win-spawn, rather than child_process.spawn, for cross platform goodness