Add test for Proximity API
#1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alrra it'd be good to add a deep link if possible to that information in the meta data |
@ryanseddon it's not. |
|
As is, this is a 👎 from me - firefox desktop triggers a false positive. Personally, I think that "Devices without such a sensor may support those events but will never fire them" is a broken API, for the same reason we don't say that desktop browsers have touchscreens. But, thats beside the point. could as |
|
ping @alrra |
|
@patrickkettner Updated! Let me know if I need to change anything else. |
| Modernizr.addAsyncTest(function () { | ||
|
|
||
| var timeout; | ||
| var timeoutTime = 300; |
There was a problem hiding this comment.
@patrickkettner 300 because I've seen it used before.
patrickkettner
added a commit
that referenced
this pull request
Nov 27, 2014
Add test for `Proximity API`
patrickkettner
added a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Add test for `Proximity API`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W3C Specification: http://www.w3.org/TR/proximity/
Test page: click me!
Test page in action (using the latest Firefox Beta for Android):
There is one detail that is currently included in the MDN link, namely:that I think is important, and which I don't know if should be included somewhere inline or not. (Cc: @patrickkettner)