Detect emoji support on Windows 7+

[aroben]

U+1F603 SMILING FACE WITH OPEN MOUTH is just an outline on Windows, so we weren't detecting that anything was drawn at all. Now we use U+1F428 KOALA instead, which is filled in by the Windows emoji font (Segoe UI Symbol). Since these emoji are monochrome on Windows 7/8, we set the fill color to red to ensure we get a non-zero red value from the pixel we sample.

[patrickkettner]

Does setting the fill color not create a background on the smiley?

[aroben]

Nope, it looks like this:

[aroben]

Here's the koala for comparison:

I also tested that this change continues to detect emoji support correctly on OS X in Safari (supported) and Chrome (unsupported).

[patrickkettner]

seems reasonable, I want to check the broader browser support to make sure we aren;t losing/gaining anyone else.

In the mean time, couldyou swap out those quotes travis is complaining about and rebase down to a single commit?

thanks @aroben !

[patrickkettner]

oop, missed that you had pushed the change already - can you rebase? thanks again!

[aroben]

Rebased!

[patrickkettner]

like a machine, you are

[patrickkettner]

support is identical across the board from my tests (IE 6-11, FF 3-26, Chrome 1-35, Safari 5-7, iOS 5-8, Android 1.5-4.2).

great catch, and wonderful PR, @aroben

[aroben]

Thanks for making it so easy! ❤️

[patrickkettner]

right back at cha, slick

On Thu, Jun 19, 2014 at 2:44 PM, Adam Roben notifications@github.com
wrote:

Thanks for making it so easy! [image: ❤️]

—
Reply to this email directly or view it on GitHub
#1377 (comment).

patrick