Add bang so minification is easier #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the minification that's used having the `/*! ... comment ..*/` is helpful. I suggest adding the bang here so the custom builds do not have to modify the source that's generated and add a `!` to ensure they maintain the MIT copyright when minifying. I think it's the custom build that reads from this file to add the license. I could be wrong, in which case, I hope the thing that does the custom build adds the `!` to the start of the copyright/license comment.
|
Hey @garrypolley!
Which situations are that? |
|
@patrickkettner Thanks for responding. Specifically we are using the uglifier minifier with a Rails application. When we make a custom build of Modernizr it does not include the It may not seem like a big deal, but it's important to us to attribute all the awesome libraries (like this one) that we use in our production code. We'd prefer not to have to modify the source to keep the license comment. |
|
Nah, totally cool with adding the |
patrickkettner
added a commit
that referenced
this pull request
Jan 12, 2015
Add bang so minification is easier
patrickkettner
added a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Add bang so minification is easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the minification that's used having the
/*! ... comment ..*/is helpful. I suggest adding the bang here so the custom builds do not have to modify the source that's generated and add a!to ensure they maintain the MIT copyright when minifying.I think it's the custom build that reads from this file to add the license. I could be wrong, in which case, I hope the thing that does the custom build adds the
!to the start of the copyright/license comment.