Fixed a regression on webkit family browsers with devicePixelRatio 1

[teebot]

Shifting the image detection by a few pixels seems to solve a false negative on chrome and safari with devicePixelRatio 1.

[ryanseddon]

An this still returns results correctly in all others?

[teebot]

I just retested deviceRatio 1 and 2, it still fails for one browser:
Windows 8
IE 9 to 11 pass
Firefox 36 pass
Chrome 41 fail

OSX
Safari pass
Firefox 36 pass
Chrome 41 pass

Is there a more reliable way to detect emojis than the print/sample method?
The implementation of emojis is so different from an OS/Browser combination to the other that it's maybe worth splitting the heuristics by case. What do you think?

[patrickkettner]

what do you mean when you say fail? chrome for windows does not support
emoji, so a "fail" would mean you get a positive result there.

On Fri, Mar 13, 2015 at 3:25 AM, Thibaut Nguyen notifications@github.com
wrote:

I just retested deviceRatio 1 and 2, it still fails for one browser:
Windows 8
IE 9 to 11 pass
Firefox 36 pass
Chrome 41 fail

OSX
Safari pass
Firefox 36 pass
Chrome 41 pass

Is there a more reliable way to detect emojis than the print/sample method?
The implementation of emojis is so different from an OS/Browser
combination to the other that it's maybe worth splitting the heuristics by
case. What do you think?

—
Reply to this email directly or view it on GitHub
#1554 (comment).

patrick

[teebot]

oh ok I thought they had implemented it