New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use `roundedEquals` to test vw and vh units #2264

Merged

patrickkettner merged 1 commit into Modernizr:master from jayeb:fix-cssvwunit

Mar 5, 2018

Contributor

jayeb commented Nov 14, 2017

This PR is intended to replace #1570, which has gone very stale and isn't automatically mergeable. From that PR:

This fixes #1569 by assuming window.innerHeight, window.innerWidth may be rounded normally, floored, ceiled, etc by the browser. This test still fails in Safari when you're zoomed in, but it did before, and I have not been able to find away around it since Safari's vw/vh units stay the same as you zoom in.

See that thread for further discussion.


          Use roundedEquals to test vw and vh units

f32ea3c

rejas mentioned this pull request

Bugfix release proposal #2295

Closed

patrickkettner merged commit baab13f into Modernizr:master

rejas mentioned this pull request

cssvwunit, cssvhunit: test #modernizr width as a float and support round... #1570

Closed

rejas mentioned this pull request

Fix issue #1805 #2452

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment