Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy detection #2459

Merged
merged 3 commits into from Jun 24, 2019
Merged

Add proxy detection #2459

merged 3 commits into from Jun 24, 2019

Conversation

BrockBeaudry
Copy link
Contributor

  • Adds detection for the Proxy object

https://caniuse.com/#feat=proxy

@BrockBeaudry BrockBeaudry mentioned this pull request Jun 24, 2019
Closed
rejas
rejas requested changes Jun 24, 2019
View reviewed changes
Copy link
Member

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small docs update if you want, otherwise okay :-) thanks!

feature-detects/proxy.js
{
"name": "Proxy Object",
"property": "Proxy",
"caniuse": "proxy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add a authors tag here with you name/userhandle if you want :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thanks for the suggestion

feature-detects/proxy.js Outdated
"name": "Proxy Object",
"property": "Proxy",
"caniuse": "proxy",
"tags": ["dom"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be an idea to put it in the dom directory if it has that tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it actually has this tag so I went ahead and removed it

@rejas rejas added this to the Modernizr v3.8 milestone Jun 24, 2019
@rejas rejas merged commit d9305fe into Modernizr:master Jun 24, 2019
@rejas
Copy link
Member

rejas commented Jun 24, 2019

Thx for the PR.

@BrockBeaudry BrockBeaudry deleted the proxy-feature-detect branch June 25, 2019 16:35
@BrockBeaudry BrockBeaudry restored the proxy-feature-detect branch June 25, 2019 16:35
@IamManchanda IamManchanda mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Modernizr v3.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrockBeaudry @rejas