Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 rest parameters test #2516

Merged
merged 7 commits into from Mar 19, 2020
Merged

ES6 rest parameters test #2516

merged 7 commits into from Mar 19, 2020

Conversation

dabretin
Copy link
Contributor

Check for rest parameters (implement in ES6)
function check(...rest) {}

@rejas
Copy link
Member

rejas commented Mar 16, 2020

this would fix #2511, right?

@dabretin
Copy link
Contributor Author

You're right => closed

@dabretin
Copy link
Contributor Author

dabretin commented Mar 17, 2020

Just a question:
For consistency, check for spread operator must exists (it's the opposite of rest parameter).
I think it have to be a separate one but what's your preference ?

@rejas
Copy link
Member

rejas commented Mar 17, 2020

Yeah, seperate feature-detect would be my preference too

@rejas
Copy link
Member

rejas commented Mar 19, 2020

so, last one left, right? :-)

@dabretin
Copy link
Contributor Author

Yes :)
But I dunno how to commit requested changes...

@dabretin dabretin requested a review from rejas March 19, 2020 19:08
@rejas rejas merged commit 49dc9d3 into Modernizr:master Mar 19, 2020
@rejas
Copy link
Member

rejas commented Mar 19, 2020

Thx a lot for your work!

@dabretin
Copy link
Contributor Author

Ur welcome.
It's a honor to contribute to this great project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants