Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caniuse mappings #2535

Merged
merged 2 commits into from Apr 17, 2020
Merged

Add caniuse mappings #2535

merged 2 commits into from Apr 17, 2020

Conversation

Markel
Copy link
Contributor

@Markel Markel commented Apr 15, 2020

Add the mappings that @PavMel pointed out in #2519, so this would then close #2519

I only have doubts with csschunit and cssexunit in which the rem page of caniuse is used, but as far as I know they are not the same.

Co-Authored-By: PavMel pavmel@users.noreply.github.com

Co-Authored-By: PavMel <pavmel@users.noreply.github.com>
Copy link
Member

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, only a few glitches in there

feature-detects/css/chunit.js Outdated Show resolved Hide resolved
feature-detects/css/exunit.js Outdated Show resolved Hide resolved
feature-detects/inputsearchevent.js Outdated Show resolved Hide resolved
feature-detects/pointerevents.js Outdated Show resolved Hide resolved
@Markel
Copy link
Contributor Author

Markel commented Apr 17, 2020

Okay, just made the changes to the properties you told me :)

@Markel Markel requested a review from rejas April 17, 2020 15:36
@rejas rejas merged commit 3b0eb2b into Modernizr:master Apr 17, 2020
@rejas
Copy link
Member

rejas commented Apr 17, 2020

Looks good, thx for the quick rework!

@rejas rejas added this to the Modernizr v3.11 milestone Apr 17, 2020
@Markel
Copy link
Contributor Author

Markel commented Apr 17, 2020

Looks good, thx for the quick rework!

Things of the quarantine 😅

@rejas rejas mentioned this pull request Apr 26, 2020
7 tasks
@Markel Markel mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible missing caniuse mappings
2 participants