Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for CSS regions support #541

Merged
merged 4 commits into from
Apr 15, 2012
Merged

Adding test for CSS regions support #541

merged 4 commits into from
Apr 15, 2012

Conversation

mibalan
Copy link
Contributor

@mibalan mibalan commented Mar 30, 2012

Fix for #528, based on parsing of the flow-into property only. Implemented as an add-on.

@matthewrobertson
Copy link

For now, the behaviour based check is the only way this is going to work in chrome canary. Please see my comment in #528

@addyosmani
Copy link
Contributor

Given the behaviour based check is the only way this can work until CSS regions are considered stable, I would say this is good to go.

@mibalan
Copy link
Contributor Author

mibalan commented Apr 9, 2012

OK, so this should be it - behavior-based, slimmer, more reliable and with a lot more comments :)

As far as I know, IE10 currently only allows use of CSS Regions on iframe-s, but that's not included in my code (mainly because it's very likely IE will update to a more spec-compliant behavior (since they're co-authoring it, too) ).

@mibalan
Copy link
Contributor Author

mibalan commented Apr 10, 2012

@schmidsi thanks a lot for the tip. It seems that my approach generated invalid flow names, hence the false negative. I fixed the code, settling for a fixed, hardcoded, unlikely to be duplicated flow name :)

@paulirish
Copy link
Member

pulling! thanks for this very fine work!

paulirish added a commit that referenced this pull request Apr 15, 2012
Adding test for CSS regions support
@paulirish paulirish merged commit d1f72d2 into Modernizr:master Apr 15, 2012
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Adding test for CSS regions support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants