pointerlock API feature detect #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,4 @@ | |||
| // https://developer.mozilla.org/en-US/docs/API/Pointer_Lock_API | |||
|
|
|||
| Modernizr.addTest('pointerlock',!!Modernizr.prefixed('pointerLockElement', document)); | |||
There was a problem hiding this comment.
I'd probably have went with
Modernizr.prefixed('requestPointerLock', window)But it doesnt seem to matter much. Spec likes both. http://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html
|
I'm 👍 as long as no one else has qualms |
|
It only talks about the Element and Document interface in the link has to be an actual element to do any pointerlock stuff any right? You're essentially requesting pointerlock access to a specific element. So LGTM. |
paulirish
added a commit
that referenced
this pull request
Aug 20, 2012
pointerlock API feature detect
|
merged. |
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
pointerlock API feature detect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This seemed too easy- let me know if I've missed the hard part.
John