Adding requestAutocomplete feature detect #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulirish is there anything else I can do to help this PR along? do I push this myself? |
|
Our codebase has changed quite a bit since you filed this, so could you make a few tweaks to match the new structure? (example)
And can we change the name from Expect you'll want to pull from master first. Then I'm happy to merge it. Thanks :) |
|
Re: naming, I copied from requestAninationFrame which is 'raf'. Did we not want to match this? https://github.com/Modernizr/Modernizr/blob/master/feature-detects/requestanimationframe.js I'll get unlazy and merge soon. |
|
hey @stucox please take another look, thanks! |
|
Yep, looks good – thanks. |
stucox
pushed a commit
that referenced
this pull request
May 28, 2013
Adding requestAutocomplete feature detect
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Adding requestAutocomplete feature detect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some background:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html
https://bugs.webkit.org/show_bug.cgi?id=100560