Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start metadata updates from our mailing list discussion #830

Merged
merged 6 commits into from
Feb 24, 2013

Conversation

SlexAxton
Copy link
Member

Namely move to:

"notes": []

and

"warnings" : []

Right now I have complex objects going into notes so it can be a link and a description of what that link is. I'd imagine we can just test: if (typeof notes[i] == 'string') and handle regular notes that way too, so only go complex if it's a link.

I also added a doc parser. Write markdown inside of a comment that looks like this:

/* DOC

## Markdown Goes here

* and stuff
* and stuff

*/

That gets parsed out and converted to html and put in the doc property of the metadata.

I also have a line commented out that will remove the metadata and docs and then convert the actual code to syntax highlighted html. I figured we could do this entirely client side though, so it's commented out for now.

I also added the field caniuse -- so we can directly relate tests back to the caniuse api or embeds. So when you add a test, see if it has a corresponding caniuse id and put it in the metadata.

<iframe src="http://caniuse.com/[feat_id]/embed/"></iframe>

would probably be the easiest integration for launch, but we could even build our own little UI from the api if we wanted.

LASTLY,

I parse out the dependencies that each test has so we can implement the feature in the builder that auto-selects dependencies. In the new one, though, I think it'd be better to have 3-state checkboxes. Selected, Depended-On, Off. The URL would only reflect the 'selected' group, so if a dependency changes in a future version, you don't have cruft for no reason.

Might merge if I get too far tonight, but happy for a little review. Code is likely fine, but I'm sure there's some discussion to be had on the comment thingy that delimits docs.

I'll begin porting docs and stuff tonight/tomorrow as well.

@SlexAxton
Copy link
Member Author

Merging for great good.

SlexAxton added a commit that referenced this pull request Feb 24, 2013
Start metadata updates from our mailing list discussion
@SlexAxton SlexAxton merged commit 113727d into Modernizr:master Feb 24, 2013
@stucox
Copy link
Member

stucox commented Feb 24, 2013

Nice one!

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Start metadata updates from our mailing list discussion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants